fix: code changes for resolving Critical and High vulnerabilities in the security tab of DKM repo. #519
Open
Akhileswara-Microsoft wants to merge 55 commits intomicrosoft:mainfrom
Open
fix: code changes for resolving Critical and High vulnerabilities in the security tab of DKM repo. #519Akhileswara-Microsoft wants to merge 55 commits intomicrosoft:mainfrom
Akhileswara-Microsoft wants to merge 55 commits intomicrosoft:mainfrom
Conversation
Akhileswara-Microsoft
requested review from
Avijit-Microsoft,
Dongbumlee,
Prajwal-Microsoft,
Roopan-Microsoft,
Vinay-Microsoft,
aniaroramsft,
dgp10801,
nchandhi and
toherman-msft
as code owners
There was a problem hiding this comment.
Pull request overview
This pull request addresses Critical and High security vulnerabilities identified in the DKM repository's security tab. The changes focus on preventing log injection attacks and improving secure random number generation.
Key Changes:
- Implements log injection prevention across C# logging statements by sanitizing carriage return (
\r) and newline (\n) characters from user-controlled input before logging - Replaces insecure
Math.random()-based UUID generation with cryptographically securecrypto.getRandomValues()implementation in the frontend - Adds
X-Frame-Options: DENYsecurity header to prevent clickjacking attacks
Reviewed changes
Copilot reviewed 25 out of 25 changed files in this pull request and generated 27 comments.
Show a summary per file
| File | Description |
|---|---|
| App/kernel-memory/service/Service.AspNetCore/WebAPIEndpoints.cs | Sanitizes index names, document IDs, and filenames in log statements to prevent log injection |
| App/kernel-memory/service/Core/Pipeline/InProcessPipelineOrchestrator.cs | Sanitizes pipeline index and document ID in error and info logs |
| App/kernel-memory/service/Core/Pipeline/BaseOrchestrator.cs | Sanitizes pipeline identifiers in debug logs |
| App/kernel-memory/service/Core/Handlers/TextPartitioningHandler.cs | Sanitizes pipeline identifiers in debug and warning logs |
| App/kernel-memory/service/Core/Handlers/TextExtractionHandler.cs | Sanitizes pipeline identifiers in debug logs |
| App/kernel-memory/service/Core/Handlers/SummarizationParallelHandler.cs | Sanitizes pipeline identifiers in debug logs |
| App/kernel-memory/service/Core/Handlers/SummarizationHandler.cs | Sanitizes pipeline identifiers in debug logs |
| App/kernel-memory/service/Core/Handlers/SaveRecordsHandler.cs | Sanitizes pipeline identifiers, record IDs, and index names across multiple log statements |
| App/kernel-memory/service/Core/Handlers/KeywordExtractingHandler.cs | Sanitizes pipeline identifiers in debug logs |
| App/kernel-memory/service/Core/Handlers/GenerateEmbeddingsParallelHandler.cs | Sanitizes pipeline identifiers and generator type names in trace logs |
| App/kernel-memory/service/Core/Handlers/GenerateEmbeddingsHandlerBase.cs | Sanitizes pipeline identifiers and sub-step names in trace logs |
| App/kernel-memory/service/Core/Handlers/GenerateEmbeddingsHandler.cs | Sanitizes pipeline identifiers and generator type names in trace logs |
| App/kernel-memory/service/Core/Handlers/DeleteIndexHandler.cs | Sanitizes pipeline identifiers in debug logs |
| App/kernel-memory/service/Core/Handlers/DeleteGeneratedFilesHandler.cs | Sanitizes pipeline identifiers in debug logs |
| App/kernel-memory/service/Core/Handlers/DeleteDocumentHandler.cs | Sanitizes pipeline identifiers in debug logs |
| App/kernel-memory/service/Core/FileSystem/DevTools/VolatileFileSystem.cs | Sanitizes file paths in error logs |
| App/kernel-memory/service/Core/FileSystem/DevTools/DiskFileSystem.cs | Sanitizes file paths in warning, trace, error, and debug logs |
| App/kernel-memory/service/Core/DocumentStorage/DevTools/SimpleFileStorage.cs | Sanitizes index, document ID, and filename in error logs |
| App/kernel-memory/extensions/Elasticsearch/Elasticsearch/ElasticsearchMemory.cs | Sanitizes search text, index names, and filter debug strings in trace logs |
| App/kernel-memory/extensions/AzureBlobs/AzureBlobsStorage.cs | Sanitizes blob names, file paths, and prefixes in various log levels |
| App/kernel-memory/extensions/AzureAISearch/AzureAISearch/AzureAISearchMemory.cs | Sanitizes record IDs and index names in debug and trace logs |
| App/kernel-memory/extensions/AWS/S3/AWSS3Storage.cs | Sanitizes index names, object keys, and prefixes in trace, warning, and info logs |
| App/frontend-app/src/components/documentViewer/pageNumberTab.tsx | Implements URL sanitization to prevent CRLF injection in storage URLs |
| App/frontend-app/src/components/chat/chatRoom.tsx | Replaces insecure UUID generation with cryptographically secure implementation using Web Crypto API |
| App/frontend-app/public/web.config | Adds X-Frame-Options header to prevent clickjacking attacks |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
App/kernel-memory/service/Core/Handlers/TextExtractionHandler.cs
Outdated
Show resolved
Hide resolved
App/kernel-memory/service/Core/Handlers/SummarizationHandler.cs
Outdated
Show resolved
Hide resolved
App/kernel-memory/service/Core/Handlers/DeleteDocumentHandler.cs
Outdated
Show resolved
Hide resolved
App/kernel-memory/service/Core/Handlers/GenerateEmbeddingsHandler.cs
Outdated
Show resolved
Hide resolved
App/kernel-memory/service/Core/Handlers/GenerateEmbeddingsHandler.cs
Outdated
Show resolved
Hide resolved
App/kernel-memory/service/Core/FileSystem/DevTools/DiskFileSystem.cs
Outdated
Show resolved
Hide resolved
App/kernel-memory/service/Service.AspNetCore/WebAPIEndpoints.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 25 out of 25 changed files in this pull request and generated 10 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
App/kernel-memory/service/Service.AspNetCore/WebAPIEndpoints.cs
Outdated
Show resolved
Hide resolved
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
App/kernel-memory/extensions/Elasticsearch/Elasticsearch/ElasticsearchMemory.cs
Fixed
Show fixed
Hide fixed
App/kernel-memory/extensions/Elasticsearch/Elasticsearch/ElasticsearchMemory.cs
Fixed
Show fixed
Hide fixed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information